Repository navigation
Test non-blocking receive interface in Kotlin - #1927
Merged
Merged
Conversation
The FFI bindings for the two-phase validation API landed in 3d6305d with integration tests for C#, Dart, JavaScript, and Python. Kotlin was left out. Run the Kotlin v2-to-v2 integration test in both callback and nonblocking transition modes, matching the other bindings. Checklist and marked checklist item handles are closed after use, consistent with how the rest of the test manages uniffi objects.
Collaborator
Coverage Report for CI Build 36626064208Coverage remained the same at 87.072%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
3 tasks done
caarloshenriq
approved these changes
Oct 6, 2026
caarloshenriq
left a comment
caarloshenriq
left a comment
Contributor
There was a problem hiding this comment.
tACK 7c905c5
Ran nix develop .#kotlin -c bash ./payjoin-ffi/kotlin/contrib/test.sh, both v2ToV2PayjoinCallback and v2ToV2PayjoinNonblocking pass.
Collaborator
|
tACK |
chavic
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kotlin was unintentionally left out of updates in #1446, this rectifies that. This will run the Kotlin v2-to-v2 integration test in both callback and nonblocking transition modes, matching the other bindings.
Closes #1919 .
Assigning @chavic to review.
Disclosure: co-authored by Claude Code
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.
reviewer
in the body of this PR.