Repository navigation
Bump bindings for payjoin 1.2.0 - #1945
Merged
Merged
Conversation
This bump is not backwards compatible to is a minor bump instead of a patch release due to the `BuildReceiverError` and `BuildSenderError` renaming.
This is a minor release and not a patch because of the breaking change caused by the `BuildReceiverError` and `BuildSenderError` renames.
This is a minor release and not a patch because of the breaking change from the `BuildReceiverError` and `BuildSenderError` renames.
This is a minor release instead of a patch release because there is a breaking change with the `BuildReceiverError` and `BuildSenderError` renames.
3 tasks done
Collaborator
Coverage Report for CI Build 37197030790Coverage remained the same at 87.494%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
spacebear21
approved these changes
Oct 5, 2026
| ## Stability | ||
|
|
||
| The package is pre-1.0 while the C# API stabilizes; expect breaking changes between 0.x releases. The version's build metadata names the wrapped payjoin core release, so `0.1.0+payjoin-1.0.0` packages payjoin 1.0.0, the first stable payjoin release. | ||
| The package is pre-1.0 while the C# API stabilizes; expect breaking changes between 0.x releases. The version's build metadata names the wrapped payjoin core release, so `0.2.0+payjoin-1.2.0` packages payjoin 1.2.0. |
Collaborator
There was a problem hiding this comment.
This seems unnecessary to update with every release. Maybe Xs and Ys as placeholders?
Member
Author
There was a problem hiding this comment.
Yeah, making this deterministic or better yet as you suggest static if it can't be removed is the way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These bump each binding language save for Kotlin which still does not have any release mechanism.
Each binding release is a minor release instead of a patch as the
BuildReceiverErrorandBuildSenderErrorare breaking changes.GLM 5.3 wrote the changelog
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.
reviewer
in the body of this PR.