Repository navigation
Conversation
Collaborator
Coverage Report for CI Build 38798921508Coverage remained the same at 87.475%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Member
|
Have we even gone through a 1.0 checklist to figure out if the API is 1.0 worthy yet? I thought we were ~payjoin-ffi-0.25.0 here? |
Member
|
my precise issue with this is that it seems like it conflates 2 things, testing our new bump script and getting #1654 out, and attempting to commit to payjoin-ffi 1.0 |
Collaborator
Author
|
Yeah I misunderstood the plan for the bump. This should be 0.25.0-rc.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump payjoin-ffi to rc.0 to drop the payjoin crate version from the release tag.
Changelog reflects that more simply as.
- Wraps payjoin 1.2.0We don't need llms where we're going we have... automation.
Pull Request Checklist
Please confirm the following before requesting review: