Skip to content

Bump payjoin-ffi version to 1.0.0-rc.0 - #1979

Closed
benalleng wants to merge 1 commit into
payjoin:masterfrom
benalleng:bump-payjoin-ffi-1.0.0-rc.0
Closed

benalleng wants to merge 1 commit into
payjoin:masterfrom
benalleng:bump-payjoin-ffi-1.0.0-rc.0

Conversation

@benalleng

Copy link
Copy Markdown
Collaborator

Bump payjoin-ffi to rc.0 to drop the payjoin crate version from the release tag.

Changelog reflects that more simply as.

- Wraps payjoin 1.2.0

We don't need llms where we're going we have... automation.

Pull Request Checklist

Please confirm the following before requesting review:

@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 38798921508

Coverage remained the same at 87.475%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 17860
Covered Lines: 15623
Line Coverage: 87.47%
Coverage Strength: 319.55 hits per line

💛 - Coveralls

@DanGould

Copy link
Copy Markdown
Member

Have we even gone through a 1.0 checklist to figure out if the API is 1.0 worthy yet? I thought we were ~payjoin-ffi-0.25.0 here?

@DanGould

Copy link
Copy Markdown
Member

my precise issue with this is that it seems like it conflates 2 things, testing our new bump script and getting #1654 out, and attempting to commit to payjoin-ffi 1.0

@benalleng

Copy link
Copy Markdown
Collaborator Author

Yeah I misunderstood the plan for the bump. This should be 0.25.0-rc.0

@benalleng benalleng closed this Oct 16, 2026
@benalleng
benalleng deleted the bump-payjoin-ffi-1.0.0-rc.0 branch October 16, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants