Skip to content

Replace corepc-node with bitcoind 0.43.2 - #2001

Merged
benalleng merged 1 commit into
payjoin:masterfrom
benalleng:corepc-node-zip-update
Oct 22, 2026
Merged

benalleng merged 1 commit into
payjoin:masterfrom
benalleng:corepc-node-zip-update

Conversation

@benalleng

Copy link
Copy Markdown
Collaborator

Following the zip yank-unyank bafoonery we have since removed the zip dependency from corepc now named bitcoind.

Hand-slopped

Pull Request Checklist

Please confirm the following before requesting review:

@benalleng benalleng changed the title Replace corepc-node with bitcoind 0.43.3 Replace corepc-node with bitcoind 0.43.2 Oct 22, 2026
@benalleng
benalleng force-pushed the corepc-node-zip-update branch 2 times, most recently from d246b26 to 33f7fd8 Compare October 22, 2026 08:20
DanGould
DanGould previously approved these changes Oct 22, 2026

@DanGould DanGould left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK 33f7fd8

@benalleng
benalleng force-pushed the corepc-node-zip-update branch 2 times, most recently from 854ba39 to a19bf4c Compare October 22, 2026 08:49
@coveralls

coveralls commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 39756094863

Coverage remained the same at 87.471%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 1 uncovered change across 1 file (7 of 8 lines covered, 87.5%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
payjoin-test-utils/src/lib.rs 8 7 87.5%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 17854
Covered Lines: 15617
Line Coverage: 87.47%
Coverage Strength: 319.84 hits per line

💛 - Coveralls

Following the zip yank-unyank bafoonery we have since removed the zip
dependency from corepc now named bitcoind.
@benalleng
benalleng force-pushed the corepc-node-zip-update branch from a19bf4c to 4493591 Compare October 22, 2026 09:31

@spacebear21 spacebear21 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 4493591

@benalleng
benalleng merged commit 0b2ac00 into payjoin:master Oct 22, 2026
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants