Repository navigation
Fix failing reproducibility checks - #2003
Merged
spacebear21 merged 1 commit intoOct 22, 2026
Merged
Conversation
The staged Dart package takes payjoin-ffi from the pinned revision but payjoin and payjoin-mailroom from crates.io. Staging only switched a crate to the revision when its required version was missing from crates.io. A pull request that changes core without a version bump, which is how core changes normally land, kept the crates.io core, so the reproducible-linux job compiled the pull request's payjoin-ffi against an older payjoin and failed. payjoin#1971 hits this with new Monitor receiver methods. Add a --core-from-revision option that always patches the sibling release crates to the pinned revision and writes the UNPUBLISHED_CORE marker publish.sh refuses, and pass it on pull request runs only. Release runs keep staging against crates.io, so an unpublished core still fails there before anything is published. This also drops the crates.io API probing.
Collaborator
Coverage Report for CI Build 39756017738Coverage remained the same at 87.471%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
benalleng
approved these changes
Oct 22, 2026
Collaborator
Author
Collaborator
|
FYI some feedback from claude: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out code changes sometimes!
Reviewer: @xstoicunicornx can you please rebase #1971 on top of this to confirm that it fixes CI?
Pull Request Checklist
Please confirm the following before requesting review: