Skip to content

Remove tar as a dependency in payjoin-test-utils - #2011

Merged
spacebear21 merged 1 commit into
payjoin:masterfrom
benalleng:remove-tar
Oct 28, 2026
Merged

spacebear21 merged 1 commit into
payjoin:masterfrom
benalleng:remove-tar

Conversation

@benalleng

Copy link
Copy Markdown
Collaborator

Following the update from corepc-node@0.12 to bitcoind@0.43.2 tar is nolonger a transitive dependency in this crate at all so the pinning to prevent MSRV issues is not necessary.

Pull Request Checklist

Please confirm the following before requesting review:

@coveralls

coveralls commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 40703961962

Coverage remained the same at 87.471%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 17854
Covered Lines: 15617
Line Coverage: 87.47%
Coverage Strength: 319.85 hits per line

💛 - Coveralls

@caarloshenriq caarloshenriq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b37e3d8

spacebear21
spacebear21 previously approved these changes Oct 28, 2026

@spacebear21 spacebear21 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@spacebear21

Copy link
Copy Markdown
Collaborator

@benalleng there is a merge conflict

Following the update from corepc-node@0.12 to bitcoind@0.43.2 tar is
nolonger a transitive dependency in this crate at all so the pinning to
prevent MSRV issues is not necessary.

@spacebear21 spacebear21 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reACK

@spacebear21
spacebear21 merged commit bc35386 into payjoin:master Oct 28, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants