Repository navigation
Add EDF material factors (GRP, welded/machined 316, exotic material) - #12
Open
marwenchaabouni wants to merge 1 commit into
Open
marwenchaabouni wants to merge 1 commit into
marwenchaabouni wants to merge 1 commit into
Conversation
Five rows on Equipment.material_factors from Aromada, Eldrup & Øi (2021), Int. J. Greenhouse Gas Control 110, 103394, Table 4 (EDF method): 316 stainless steel welded 1.75 and machined 1.30, glass-reinforced plastic 1.40, exotic material welded 2.50 and machined 1.75. Same basis as the existing table, carbon steel 1.00, applied to the equipment and piping part of the cost only. Docs material table and source line updated. No existing row changed. Part of pbtamarona#10.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #10.
Adds the EDF material-factor set agreed in that thread. Five rows join
Equipment.material_factors, all from Aromada, Eldrup & Øi (2021), Int. J. Greenhouse Gas Control 110, 103394, Table 4 (EDF method):Same basis as the existing table: carbon steel = 1.00, applied to the equipment and piping part of the cost only.
The paper names glass-reinforced plastic (GRP), the common case of glass-fibre FRP. The paper does not define what "exotic material" covers, so the key is added generally and titanium and zirconium are not mapped to it.
Files:
src/openpytea/equipment.py(dict and docstring range),docs/user_guide/equipment.rst(materials table and source line). No existing row changed.