Conversation
… messages to indicate the line and column, and fix subtype handling accordingly
…pdate the git link of fork of Paraconf
…of an hdf5 compatibility test
| context().logger().trace("`{}' will be serialized", desc_name); | ||
| std::string serialized_name = PDI::to_string(value); | ||
| context().desc(serialized_name); | ||
| m_desc_to_serialize.emplace(desc_name, serialized_name); |
There was a problem hiding this comment.
To allow dynamically defined member of serialize
| [submodule "vendor/run-clang-format"] | ||
| path = vendor/run-clang-format | ||
| url = https://github.com/Sarcasm/run-clang-format.git | ||
| [submodule "vendor/paraconf-X"] |
There was a problem hiding this comment.
This PDI branch is based on a specific Paraconf branch
| { | ||
| string order_str = to_string(PC_get(node, ".order"), ""); | ||
| if (order_str == "c" && order_str == "C") { | ||
| if (order_str == "c" || order_str == "C") { |
There was a problem hiding this comment.
Error, condition could never be matched
| return unique_ptr<Tuple_template>{ | ||
| new Tuple_template{get_tuple_elements(ctx, elements_node, tuple_buffersize_defined), std::move(tuple_buffersize), node} | ||
| }; | ||
| return std::make_unique<Tuple_template>( |
There was a problem hiding this comment.
make_unique instead of unique_ptr for modern C++
| auto& location = *m_location; | ||
| return fmt::format( | ||
| "{}: {}({}:{} -> {}:{}) {}", | ||
| "{}: {} (line {}, column {} to line {}, column {}) {}", |
There was a problem hiding this comment.
Less compact but more explicit
| if (type != "array" && node.node) { | ||
| if (!PC_status(PC_get(node, ".size"))) { | ||
| logger().warn("In line {}: Non-array type with a `size' property", node.node->start_mark.line); | ||
| logger().warn("In line {}: Non-array type with a `size' property", node.node->start_mark.line + 1); |
There was a problem hiding this comment.
Solve index issue, as libyaml starts its index at 0 and not 1
| " mpio: INDEPENDENT \n" | ||
| " array_data: \n" | ||
| " - memory_selection: \n" | ||
| " - mpio: INDEPENDENT \n" | ||
| " memory_selection: \n" |
There was a problem hiding this comment.
mpio was previously silently ignored
There was a problem hiding this comment.
Change equivalent to change of dnc_file_context.cxx of NetCDF
| if (!PC_status(read_node)) { | ||
| if (PDI::is_scalar(read_node)) { | ||
| std::string read_desc = PDI::to_string(read_node); | ||
| descs_to_check.emplace_back(read_node, read_desc); |
There was a problem hiding this comment.
Change needed to load data and metadata sections during the parsing, so that we can check the specification tree in an 'on_init' callback
Change equivalent to change of file_op.cxx for HDF5
…y, update git link of fork of Paraconf, fix indent
|
Will not pass CI as it uses default Paraconf (and not its specific branch) |
|
Made PR #742, #743, #744, #745 to split this PR |
1 participant
Not aimed at a particular issue, made after user feedback
To improve readability of errors related to the specification tree, on the user side
List of things to check before making a PR
Before merging your code, please check the following:
.clang-format;Fix #issuekeyword to autoclose the issue when merged.