So slow!

[stevenvachon]

Using v8.x, my test suite of 23,104 URLs takes 110 seconds to run! v4.x only takes 7 seconds, so I'll have to stick with that version for now.

Should you have used net.isIP instead of is-ip?

[jhnns]

Using v8.x, my test suite of 23,104 URLs takes 110 seconds to run! v4.x only takes 7 seconds, so I'll have to stick with that version for now.

There must be something else in your setup. I just measured it: 23,104 take roughly 7-8s, average: 0.3334ms per URL. Check it out: #244

Should you have used net.isIP instead of is-ip?

Thanks for the hint. parse-domain is designed to also work in a browser environment, where access to net.isIP is not guaranteed. Not sure if we should switch...

[stevenvachon]

Oops, it was actually 46,208 since each test had two URLs. But still, the discrepancy is huge between our tests.

I didn't use fromUrl, if that makes a difference; I ran URL::hostname into parseDomain. Most of the hostnames are "www.domain.com" (https://github.com/stevenvachon/url-relation/blob/main/test/helpers/tests.json). 🤷‍♂️

---

As for net.isIP in a browser, does net-browserify work?

[jhnns]

I didn't use fromUrl, if that makes a difference; I ran URL::hostname into parseDomain. Most of the hostnames are "www.domain.com" (https://github.com/stevenvachon/url-relation/blob/main/test/helpers/tests.json). 🤷‍♂️

I expect fromUrl to make it rather slower, actually 😁

What's the problem with is-ip?

[stevenvachon]

What's the problem with is-ip?

Nothing real other than possibly being unnecessary. It was the first thing I could blame for the performance issue.