Repository navigation
Conversation
Issue #811: a Radeon 760M at 2560x1440 was held at 30 entering a dungeon (its frames still heavy past the level load's second of grace). Held, it read 23 ms of GPU time a frame - an integrated GPU clocks down at half load - so the way back, which wants the GPU under 15 ms, never came: 30 fps until a restart, which ran the same dungeon at 60. Without Dynamic resolution nothing else looked for 60 from there. Now, once the CPU has had clear headroom for 10 s at 30 (times the backoff) and only the GPU's time keeps the hold, 60 gets a try with a hitch's grace. Its frames measure the GPU at 60: if they don't fit, the game is held again with the backoff doubled (the next try waits twice as long, up to 16x). A try that failed with the GPU over the limit at 60 and no slower at 30 (a GPU that keeps its clock) isn't repeated in that scene. The hold line after a try logs the GPU time it saw at 60. tools/test_pace.c: two #811 cases (a clocked-down iGPU that fits 60, and one that doesn't), and the GPU-bound cases' checks allow their one failed try. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #811
What changed
runtime/nvn/pace.c: when the game is held in its 30 fps mode, the CPU has clear headroom, and only the GPU's time keeps the hold, the pacer now tries 60 after 10 s at 30 (times the backoff). The try has a hitch's grace, and its frames measure the GPU at 60:After a failed try, the hold's log line includes the GPU time measured at 60 (
gpu N ms a frame at 60).Why
In the reporter's logs (Ryzen 5 8600G / Radeon 760M, 2560x1440, Vulkan, Dynamic resolution off), entering Bottle Grotto set off the hold just after the level load's one-second grace. That happened in 2 of 3 runs. In the third, the slow loading frames fell inside the grace and it never held. Held, the GPU timer read 23.2 ms a frame, because an integrated GPU lowers its clock at half load. The way back needs the GPU under 15 ms, so it never came. The game stayed at 30 for the rest of the session, even back in the field, which had run at 58-60 a minute earlier. A restart ran the same dungeon at about 60. Without Dynamic resolution, nothing else looked for 60 from that hold.
Tests
tools/test_pace.py: 22 of 22. Two new FPS drops from 60 to 30 on 8600g (760m) #811 cases:Backend: shared code (
pace.c), the same on Metal and Vulkan.Not changed here
The hold was set off by frames just past
PACE_GRACE_NSafter a level load. Giving level loads the render-scale change's "until frames settle" grace (at most 4 s) would keep this hold from starting at all. That's a separate change.🤖 Generated with Claude Code