Repository navigation
Nightly: signed update manifests and the Sparkle feed - #820
Merged
Merged
Conversation
#819) Scheduled nightlies run main's nightly.yml on develop's code, so main needs the same file. The scripts it calls (update_manifest.sh, sparkle_appcast.sh, nightly_publish.sh) come from the develop checkout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MSYS2's pkgconf 3.0.11 installs pkg-config and the target-prefixed names as links without .exe; only pkgconf.exe keeps the extension. Bash still runs them, but Python's shutil.which on Windows only matches PATHEXT names, so the delete guard and data move tests built without SDL3 flags and failed to link on windows-arm64. Fall back to pkgconf. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 9db711d) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scheduled nightlies run main's nightly.yml, so it has to match develop's after #819 (auto-update). Same file, byte for byte.
The scripts it calls (update_manifest.sh, sparkle_appcast.sh, nightly_publish.sh) run from the develop checkout, so nothing else of the updater changes on main.
Also carries #815's CI fix (the delete-guard and data-move tests find SDL3 through pkgconf), which main didn't have yet: without it windows-arm64 CI fails here.
Merge only after #819 is in develop: before that, a scheduled nightly would call scripts develop doesn't have yet.
🤖 Generated with Claude Code