Bump click from 8.4.2 to 8.5.0 - #64
Conversation
Bumps [click](https://github.com/pallets/click) from 8.4.2 to 8.5.0. - [Release notes](https://github.com/pallets/click/releases) - [Changelog](https://github.com/pallets/click/blob/main/CHANGES.md) - [Commits](pallets/click@8.4.2...8.5.0) --- updated-dependencies: - dependency-name: click dependency-version: 8.5.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
haruotsu
left a comment
There was a problem hiding this comment.
Click 8.5.0 is a feature release, so I went through the changelog for anything that touches this CLI.
Two entries could have bitten and do not:
- Colorama is dropped as a dependency (Windows enables ANSI styles natively now), which is why the lockfile loses that edge. We only ever used
click.echo, so there is nothing to adjust. - The automatic help option moves its value to the reserved name
_click_default_help, and a parameter claiming the oldhelpname now warns. No option or argument incli/__init__.pyis namedhelp, so parsing is unchanged.
click.version_option, click.Path, click.UsageError and the group/option/argument decorators we use all behave the same. Lock check, lint, format, mypy and all 875 tests pass on the branch, and gete --version and gete --help render correctly.
One follow-up, not a reason to hold this back: 8.5.0 deprecates CliRunner.isolated_filesystem, which our CLI tests use in about twenty places, and it is slated for removal in Click 9.0. The suite now emits 23 DeprecationWarnings because of it. Moving those to tmp_path with absolute paths is worth doing before the 9.0 bump arrives.
LGTM.
Bumps click from 8.4.2 to 8.5.0.
Release notes
Sourced from click's releases.
... (truncated)
Changelog
Sourced from click's changelog.
... (truncated)
Commits
8b19813Release version 8.5.02c8cd3aAdd FAQ entry aboutUnicodeEncodeErroron Windows (#3778)131c86aAdd FAQ entry aboutUnicodeEncodeErroron Windowse1fd594Add support ofpathlib.Pathtoedit(#3781)a1d8785Add support ofpathlib.Pathtoedit2103e15Forward all user's parameters set inPAGERand improve flag detection (#3777)a6256bfForwards all user's parameters set inPAGER61b69e9Resolve the pager command once, in_pager_contextmanager(#3776)9835b0fResolve the pager command once, in_pager_contextmanagerf36d58bRefactor pager stream handling (#3767)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)