Repository navigation
Speed up macOS dependency installation in CI - #847
Conversation
1604805 to
5cdd526
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
=======================================
Coverage 88.49% 88.49%
=======================================
Files 3 3
Lines 1330 1330
Branches 196 196
=======================================
Hits 1177 1177
Misses 75 75
Partials 78 78 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jeltz
left a comment
There was a problem hiding this comment.
While I agree with the direction of the change this looks like AI nonsense, especially the CPAN changes.
But what exactly you don't like? cpan downloads index file and parse it locally, while cpanm queries remote API and saves time on that. Also it's what recommended on https://www.cpan.org/modules/INSTALL.html Probably checking deps is redundant. Will drop it. |
5cdd526 to
611c2b4
Compare
|
Still looks like mostly AI nonsense. Like why the random env stuff? And since when did we start using markdown in our commit messages? And how much time do we save with cpanminus especially since we now need to install it. |
Why random?
That's just my habbit, to wrap all commands with ``, this is not an LLM part. Message itself probably are (I usually write commit messages myself). |
|
Why not |
|
Also should we add |
|
I think we either should do a minimalstic set with all the major speeduos or actually check in the manual and enable everything we find that should be enabled/disabled for automatic CI use. |
Ok, that's philosophical difference between our approaches. What are the changes from this PR good to go? This 3 minutes vs 30 seconds change. |
|
Just remove |
CI image already have update brew index, so avoid updating it. Also skip post install cleanup.
Unlike cpan, cpanm don't download whole index but queries remote API. Also it doesn't install any recommneded dependencies by default, only specified ones.
611c2b4 to
d8a2ea5
Compare
brew updatere-syncs the whole formula index on every job even though the dependencies are already current in the runner image. Skip it and suppress the implicit auto-update inbrew install.Install the Perl test modules with cpanm instead of cpan, which reconfigures and re-indexes CPAN on first use.
PG-0
Description
Links