Repository navigation
Do not use tar --recursive-unlink when unpacking layer sources - #168
Merged
Merged
Conversation
GNU tar before 1.35 (e.g. Ubuntu 22.04) tries to remove the extraction
root itself if the tarball contains "." as a member, which fails with
tar: .: Cannot unlink: Invalid argument
and makes the whole layer-init/layer-update run fail. Clear the target
directory in Python instead. This is equivalent: --recursive-unlink
emptied the same hierarchy, and tar rewrites every member on extraction
in any case, so no additional disk load.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNU tar before 1.35 (e.g. Ubuntu 22.04) tries to remove the extraction root itself if the tarball contains "." as a member, which fails with
and makes the whole layer-init/layer-update run fail. Clear the target directory in Python instead. This is equivalent: --recursive-unlink emptied the same hierarchy, and tar rewrites every member on extraction in any case, so no additional disk load.