Skip to content

docs: update CLAUDE.md for v10dev - #203

Merged
k-rister merged 1 commit into
masterfrom
docs-update-claude-md-v10dev
Aug 5, 2026
Merged

docs: update CLAUDE.md for v10dev#203
k-rister merged 1 commit into
masterfrom
docs-update-claude-md-v10dev

Conversation

@k-rister

@k-rister k-rister commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Update CLAUDE.md's Versioning section: current version is v10dev (was stale at v8dev)
  • Include v9dev and v10dev in the supported versions list
  • Note default-aggregation as the key v10dev addition

Addresses PERFNFV-466 from the architecture review — CLAUDE.md had drifted from the actual VERSION file and cdm.js's supportedCdmVersions.

Test plan

  • Diffed against VERSION file and cdm.js docTypes/supportedCdmVersions to confirm accuracy

🤖 Generated with Claude Code

CLAUDE.md still claimed v8dev was current and omitted v9dev/v10dev
from the supported versions list. Also note default-aggregation as
the key v10dev addition.

Addresses PERFNFV-466 from the architecture review.
@k-rister k-rister self-assigned this Aug 5, 2026
@k-rister
k-rister requested a review from a team August 5, 2026 14:18
@project-crucible-tracking project-crucible-tracking Bot moved this to In Progress in Crucible Tracking Aug 5, 2026

@atheurer atheurer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against VERSION file and cdm.js — v10dev, supportedCdmVersions list, and default-aggregation are all accurately described. LGTM.

@k-rister
k-rister merged commit d7e973a into master Aug 5, 2026
10 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Crucible Tracking Aug 5, 2026
@k-rister
k-rister deleted the docs-update-claude-md-v10dev branch August 5, 2026 19:22

@atheurer atheurer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified two issues against the current code before merging:

  1. Misattributed feature. The new bullet says "v10dev's key addition is default-aggregation", but per cdm.js:372 the field was added to the schema on v9dev, and cdm.js:417 has an explicit comment: // v10dev inherits default-aggregation from v9dev via deep clone. The aggregation dispatch logic (getDefaultAggregation, etc.) isn't version-gated either — it works identically on v9dev. So v10dev doesn't actually add this; it inherits it unchanged. Suggest rewording to attribute the field to v9dev+ (or note v10dev is schema-identical to v9dev and the version bump itself is the notable part).

  2. Index naming pattern is wrong for v9dev+ (pre-existing bug in the doc, but this PR touches the exact line and doesn't fix it). getIndexBaseName() explicitly adds an extra hyphen for v9dev and later (cdm-v9dev-, cdm-v10dev-, per a lab-admin OpenSearch naming convention — see the comment at line ~666), but the updated example still reads cdmv10dev-metric_data* (no hyphen after cdm). Should be cdm-v10dev-metric_data*. Since v9dev was already in the supported-versions list before this PR, this was already stale, but worth fixing while the line is being touched anyway.

The VERSION bump (v8dev -> v10dev) and the supportedCdmVersions list update are both accurate and needed. CI is green. Requesting changes just for the two content corrections above — otherwise straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants