docs: update CLAUDE.md for v10dev - #203
Conversation
CLAUDE.md still claimed v8dev was current and omitted v9dev/v10dev from the supported versions list. Also note default-aggregation as the key v10dev addition. Addresses PERFNFV-466 from the architecture review.
atheurer
left a comment
There was a problem hiding this comment.
Verified against VERSION file and cdm.js — v10dev, supportedCdmVersions list, and default-aggregation are all accurately described. LGTM.
atheurer
left a comment
There was a problem hiding this comment.
Verified two issues against the current code before merging:
-
Misattributed feature. The new bullet says "v10dev's key addition is
default-aggregation", but percdm.js:372the field was added to the schema on v9dev, andcdm.js:417has an explicit comment:// v10dev inherits default-aggregation from v9dev via deep clone. The aggregation dispatch logic (getDefaultAggregation, etc.) isn't version-gated either — it works identically on v9dev. So v10dev doesn't actually add this; it inherits it unchanged. Suggest rewording to attribute the field to v9dev+ (or note v10dev is schema-identical to v9dev and the version bump itself is the notable part). -
Index naming pattern is wrong for v9dev+ (pre-existing bug in the doc, but this PR touches the exact line and doesn't fix it).
getIndexBaseName()explicitly adds an extra hyphen for v9dev and later (cdm-v9dev-,cdm-v10dev-, per a lab-admin OpenSearch naming convention — see the comment at line ~666), but the updated example still readscdmv10dev-metric_data*(no hyphen aftercdm). Should becdm-v10dev-metric_data*. Since v9dev was already in the supported-versions list before this PR, this was already stale, but worth fixing while the line is being touched anyway.
The VERSION bump (v8dev -> v10dev) and the supportedCdmVersions list update are both accurate and needed. CI is green. Requesting changes just for the two content corrections above — otherwise straightforward.
Summary
v10dev(was stale atv8dev)v9devandv10devin the supported versions listdefault-aggregationas the key v10dev additionAddresses PERFNFV-466 from the architecture review — CLAUDE.md had drifted from the actual
VERSIONfile andcdm.js'ssupportedCdmVersions.Test plan
VERSIONfile andcdm.jsdocTypes/supportedCdmVersionsto confirm accuracy🤖 Generated with Claude Code