feat: add partial and dropped-engines fields to run doc mapping - #204
Open
k-rister wants to merge 1 commit into
Open
feat: add partial and dropped-engines fields to run doc mapping#204k-rister wants to merge 1 commit into
k-rister wants to merge 1 commit into
Conversation
Enables recording, at the run level, whether a benchmark run lost engines mid-run (roadblock timeout/crash) and which ones — supports rickshaw's upcoming participation-summary work (PERFNFV-464). Added to v9dev (inherited by v10dev) for forward compatibility with the default-aggregation precedent, so rickshaw can start emitting these fields ahead of every deployment being on v10dev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
partial(boolean) anddropped-engines(keyword) fields to therundoctype mapping (v9dev, inherited by v10dev)Context
Architecture review (PERFNFV-464) found that a crashed/dropped engine mid-run currently has no visibility beyond an in-memory log line — the run "succeeds" with fewer engines and nothing records that fact. Rickshaw will start emitting these fields on the run document; this PR adds the mapping first since the
runindex usesdynamic: "strict"— emitting the fields before the mapping exists would cause OpenSearch to reject the documents (same class of issue found in PERFNFV-455).This should merge before the rickshaw PR that emits these fields, to avoid indexing rejections on the run document.
Test plan
node -c queries/cdmq/cdm.js— syntax check passesrequire()that both v9dev and v10devrunmappings include the newpartial/dropped-enginespropertiesrundoctype document indexes successfully withpartial: false, dropped-engines: []on the happy path, andpartial: true, dropped-engines: ["client-1"]when an engine was killed mid-run🤖 Generated with Claude Code