Repository navigation
fix: disable empty information saves - #66
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Coverage
All changed paths are covered:
requireNonEmptywith blank and whitespace-only values: Save disabled and submission blocked.requireNonEmptywith a real value: Save enabled and values submitted.requireNonEmpty: existing behavior preserved./infoAdd dialogs: Address, Payment Card, and Note all opt into the guard./infoedit dialog: an existing empty record remains editable.Tests: 47 → 49 (+2 new test files). AI-assessed changed-path coverage: 100%.
Pre-Landing Review
One informational test gap was found and fixed by adding route-level coverage. Testing, maintainability, performance, and code-structure reviews are otherwise clean.
Design Review
Design Review (lite): no findings. The change uses the shared Button component's existing native disabled state.
Eval Results
No prompt-related files changed, so evals were skipped.
Scope Drift
Scope Check: CLEAN. The diff is limited to the Information modal behavior and regression tests.
Plan Completion
No relevant plan file was detected.
Verification Results
/infoflow was exercised locally before shipping.TODOS
No root
TODOS.mdexists; no unrelated tracking file was added for this focused fix.Test plan