[fix] train on trial-aligned windows for correct R² evaluation - #6
Merged
Merged
Conversation
Switch train_benchmark.py from NLBDataset (sliding windows over the full recording) to TrialAlignedDataset (one window per trial, -100ms to +500ms around move_onset_time). The sliding-window approach samples ~85% rest periods, collapsing R² to ~0; trial-aligned windows match the published NLB evaluation protocol and yield meaningful R² (Wiener baseline ~0.49). https://claude.ai/code/session_01AcwBjnbswWKkeyujGsuFzy
peterajhgraham
marked this pull request as ready for review
May 18, 2026 21:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NLBDataset(sliding windows over full recording) withTrialAlignedDatasetviabuild_trial_aligned_datasetsinscripts/train_benchmark.pymove_onset_time, yielding meaningful R² (Wiener filter baseline ~0.49)--data-rootCLI arg with--nwb-pathpointing directly to the MC_Maze train+behavior NWB filetrain_windows/val_windowskeys in the JSON output totrain_trials/val_trialsTest plan
python scripts/train_benchmark.py --nwb-path <path-to-nwb> --max-steps 100and confirm it loads without errortrain_trialsandval_trialsappear inbenchmarks/training/results_raw.jsonhttps://claude.ai/code/session_01AcwBjnbswWKkeyujGsuFzy
Generated by Claude Code