Conversation
`auto_resolved` fails strict on purpose: a finding that merely stopped appearing may have been hidden rather than fixed, and strict is the mode that refuses to take that on trust. But the merge auto-resolves for three different reasons and records them all as the same status. Two of them are not inferences. `file_deleted` is checked against the filesystem, and the zone-policy branch is read from configuration — the tool establishes both for itself. Neither leaves anything a person could fix and attest, so the finding can never reach `fixed` and never stops counting against strict. The effect is that strict decays as a codebase deletes dead code, and no amount of work recovers it. On the repository this was found on, 242 of 1553 strict failures (16%) are verified auto-resolutions; in the Test health dimension alone it is 130 of 631, which had held that dimension at 0.0 strict for eleven consecutive scans. The fix records WHY an issue auto-resolved and exempts only the two kinds the tool verified itself. `is_failure()` replaces the bare status-set test at the two scoring call sites, since a status alone cannot carry that distinction. Existing state is backfilled from the note each branch already wrote, so a repository gets the correction for its history rather than only for what it deletes next. Deliberately unchanged: the third branch, "absent from latest detector output", still fails strict — that is the case the rule exists for. `verified_strict` is untouched, and an unrecognized `resolution_kind` is not a way out, so a hand-edited state file cannot invent an exemption. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
github-actions Bot
added a commit
to citizenadam/desloppify
that referenced
this pull request
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
auto_resolvedfailsstricton purpose — a finding that merely stopped appearing may have been hidden rather than fixed, and strict is the mode that refuses to take that on trust.But
verify_disappearedauto-resolves for three different reasons and records them all as the same status:The first two are not inferences. The file is checked against the filesystem; the zone is read from configuration. The tool establishes both for itself, and neither leaves anything a person could fix and attest — so the finding can never reach
fixed, and never stops counting against strict.The effect is that strict decays as a codebase deletes dead code, and no amount of work recovers it. Deleting a dead module is a good act that permanently lowers your score.
On the repository this was found on: 242 of 1553 strict failures (16%) are verified auto-resolutions. In
Test healthalone it is 130 of 631, which had held that dimension at 0.0 strict for eleven consecutive scans — 124 of them naming files that no longer exist. The dimension was unreachable by any amount of test-writing.Fix
Record why an issue auto-resolved, and exempt from
strictonly the two kinds the tool verified itself.resolution_kind("file_deleted"/"zone_policy") is set at the two verified branches; the inferred branch explicitly setsNone.is_failure(issue, mode)replaces the barestatus not in FAILURE_STATUSES_BY_MODE[mode]test at the two scoring call sites, since a status alone cannot carry the distinction.Deliberately unchanged
verified_strictis untouched (auto_resolvedalready passes it).resolution_kindis not a way out, so a hand-edited state file cannot invent an exemption.Tests
5817 passed, 5 skipped. Seven new cases inTestVerifiedAutoResolution, covering both exempt kinds, the inferred case still failing, an unknown kind, other statuses,verified_strictinvariance, and state written before the field existed.Removing the exemption clause turns two of them red, so they fail on the unfixed code.
🤖 Generated with Claude Code