Repository navigation
fix: use ESLint CLI for Next.js 16 framework scans - #760
Open
jimmybrancaccio wants to merge 1 commit into
Open
jimmybrancaccio wants to merge 1 commit into
jimmybrancaccio wants to merge 1 commit into
Conversation
Committed by: Developer
There was a problem hiding this comment.
🟡 Changes recommended
Next.js 16 workspaces may fail module detection when dependencies are hoisted, falling back to the unsupported next lint command.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates Next.js framework lint integration to use ESLint for Next.js 16+ while preserving legacy behavior for older or unknown versions.
Changes:
- Adds per-project tool command resolution.
- Detects Next.js versions and selects the appropriate lint command.
- Adds focused behavioral and fallback tests.
File summaries
| File | Description |
|---|---|
desloppify/languages/typescript/tests/test_ts_nextjs_framework.py |
Tests version-based command selection and fallback behavior. |
desloppify/languages/_framework/frameworks/types.py |
Adds optional command resolver support. |
desloppify/languages/_framework/frameworks/specs/nextjs.py |
Selects ESLint for Next.js 16+. |
desloppify/languages/_framework/frameworks/phases.py |
Resolves tool commands per scan root. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| def _next_lint_command(scan_root: Path) -> str | None: | ||
| """Use ESLint directly when the installed Next.js no longer provides lint.""" | ||
| try: | ||
| package = json.loads((scan_root / "node_modules/next/package.json").read_text()) |
github-actions Bot
added a commit
to citizenadam/desloppify
that referenced
this pull request
Sep 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next.js 16 removed
next lint, so the framework detector currently reports reduced coverage without checking lint findings. Resolve the command from the installed Next.js version: useeslint . --format jsonon 16+, preserving the existing command when the version is older or unknown. Missing ESLint still produces reduced coverage through the existing tool runner.Adds an optional per-project command resolver to framework tool integrations. The existing ESLint JSON parser and coverage handling remain in use.
Fixes #709.
Validation:
desloppify/tests/: 5,811 passed, 3 skipped, one Nim tree-sitter failure reproduced on unchanged HEAD.--formatoption.