fix: persist strategy finding resolutions

[jimmybrancaccio]

Problem

desloppify plan resolve "strategy::<id>" --confirm reports success, but the finding remains open and desloppify next immediately returns it again. Strategy findings are state-backed work items, yet the resolve command classified their prefix as workflow-only synthetic work and never delegated to cmd_resolve.

Fix

Keep strategy IDs on the ordinary state-backed resolution path while preserving workflow, triage, and subjective synthetic handling. The regression test now verifies the split explicitly.

Validation

• python -m pytest desloppify/tests/commands/plan/test_plan_overrides_direct.py -q — 22 passed
• Real project verification: the previously looping strategy finding changed to fixed and next advanced
• Full suite: 5,811 passed, 3 skipped, with one unrelated pre-existing Nim tree-sitter grammar failure (proc_declaration unsupported by the installed grammar)

[Copilot]

Copilot review overview

🟢 Approval recommended

The change is narrowly scoped, aligns with the stated problem, and is backed by a targeted regression test that exercises the corrected classification path.

Review effort: Lite
Findings: None

What changed in this PR

This PR fixes desloppify plan resolve incorrectly treating strategy::<id> findings as workflow-only synthetic items, which prevented them from going through the normal state-backed resolution flow and left them open.

Changes:

• Adjusted synthetic pattern splitting so strategy:: IDs are treated as state-backed work items and delegated to cmd_resolve.
• Expanded the regression test to assert that strategy:: patterns remain in the “remaining” (non-synthetic) list while workflow/triage synthetics are separated.

File	Description
desloppify/​app/​commands/​plan/​override/​resolve_helpers.py	Refines synthetic detection to exclude strategy:: from workflow-only synthetics so strategy findings are resolved via state-backed logic.
desloppify/​tests/​commands/​plan/​test_plan_overrides_direct.py	Adds explicit coverage to ensure strategy:: patterns are not classified as workflow/triage synthetics.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.