Repository navigation
fix: state low-score issue contract in review prompts - #774
Open
jimmybrancaccio wants to merge 1 commit into
Open
jimmybrancaccio wants to merge 1 commit into
jimmybrancaccio wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new import block violates the configured Ruff import-sorting rule and should be merged with the existing block.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Clarifies the low-score issue contract in shared batch/external review prompts.
Changes:
- Adds the below-85 score requirement and anti-invention guidance.
- Adds regression assertions for the batch prompt.
| File | Description |
|---|---|
prompt_sections.py |
Adds shared low-score task requirements. |
test_review_batch_core_direct.py |
Verifies the new prompt contract. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+5
to
+7
| from desloppify.intelligence.review.feedback_contract import ( | ||
| LOW_SCORE_ISSUE_THRESHOLD, | ||
| ) |
github-actions Bot
added a commit
to citizenadam/desloppify
that referenced
this pull request
Sep 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
Focused review batches are rejected when they score a dimension below 85 without an issue, but the generated task requirements do not state that import contract. In a real project run, the abstraction-fitness reviewer twice returned a coherent 84 assessment with
issues: []; both runs exited successfully and were then markedparse_failed.Fix
State the existing low-score issue requirement directly in the shared task requirements used by batch and external review prompts. The wording also tells reviewers not to invent defects: when no issue is warranted, the score must remain consistent with that judgment.
Validation
python -m pytest desloppify/tests/commands/review/test_review_batch_core_direct.py -q— 22 passedpython -m pytest desloppify/tests/ -q— 5,811 passed, 3 skipped; one unrelated pre-existing Nim tree-sitter grammar mismatch