Repository navigation
Honor scan exclusions in external tool findings - #776
Draft
benjaminsehl wants to merge 1 commit into
Draft
benjaminsehl wants to merge 1 commit into
benjaminsehl wants to merge 1 commit into
Conversation
github-actions Bot
added a commit
to citizenadam/desloppify
that referenced
this pull request
Sep 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Generic external tools discover their own files, so configured Desloppify exclusions could be ignored by their diagnostics. For example, scanning a nested Swift project with
ios/.buildexcluded still reported SwiftLint violations from the generated SwiftPM test runner.Change
Filter parsed tool findings through the existing project-relative path resolver and exclusion matcher. Validate the original tool output first so an exit code indicating lint findings still succeeds when all diagnostics are excluded. Preserve parser metadata and retained findings.
Validation
3a7735d; the installed Python 3.14 tree-sitter-language-pack distribution lacks its importable module in this environment. Keeping this draft to make that validation limitation explicit.