Repository navigation
Conversation
github-actions Bot
added a commit
to citizenadam/desloppify
that referenced
this pull request
Sep 23, 2026
This was referenced Sep 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kotlin delegates and DSL operators can use imported extensions without spelling their names in the file body. The generic unused-import detector reports these imports anyway; a Kotlin unused cluster then suggests
desloppify autofix unused-imports --dry-runeven though Kotlin only registersktlint-violation.Recognize property delegates, indexing, call expressions and assignment-plugin syntax when checking Kotlin imports. Handle import aliases before matching implicit operator names. This is intentionally conservative without receiver-type resolution: an operator remains potentially used when its corresponding syntax occurs. Ordinary unused imports, comments/strings, read-only delegates and imports without matching syntax retain regression coverage.
Reuse the already validated member commands when suggesting a cluster autofix. Require every member to support the same command; otherwise keep the cluster drill-down command and omit the autofix hint. Manual cluster actions are preserved.
Validation:
getValue, 20setValue, and one each ofget,invoke,assign. Removing the three Gradle imports caused compiler errors; restoring them restored the build.python -m pytest desloppify/tests/ -q: 5,855 passed, 5 skipped, 2 failed. Both failures are the duplicatedtest_do_run_batches_dry_run_generates_packet_and_promptsassertion forPreviously flagged issues; both reproduce with the changed production files restored to upstream HEAD.git diff --checkpassed.The syntax handling covers delegates, indexing, invocation and the assignment plugin. It does not claim full Kotlin semantic import resolution or add handling for every operator convention. No project code, installed scanner, or scanner state was changed during validation.