Repository navigation
Conversation
github-actions Bot
added a commit
to citizenadam/desloppify
that referenced
this pull request
Sep 23, 2026
This was referenced Sep 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kotlin's ktlint registration uses a flat JSON parser, but ktlint reports nested
errorsarrays per file. Its default warning preamble can also invalidate JSON. This drops real findings. The generic directory formatter additionally lacks the CLI's normal no-path calling behavior and cannot constrain formatting to selected, eligible source files.Add a dedicated
ktlintparser and suppress log preambles with--log-level=none. Preserve rule and column details and give separate violations on the same line distinct identities. Malformed reporter output raises a parser error instead of appearing clean.Use a Kotlin-specific fixer that formats selected eligible files through stdin and validates the result before atomically writing it. This respects configured exclusions and never treats filenames as globs. Dry runs do not write. Invalid syntax, failed tools, malformed validation output, and concurrent source edits preserve the original file. Permissions are retained. Remaining uncorrectable violations stay unresolved for the next scan. Other language fixers are unchanged.
Validation:
git diff --checkpassed.Full
python -m pytest desloppify/tests/ -q: 5,826 passed, 5 skipped, 2 failed. Both failures are duplicated review-prompt tests assertingPreviously flagged issues; both also fail against the unchanged upstream base.