Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions desloppify/engine/detectors/patterns/security.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@
)

SENSITIVE_IN_LOG = re.compile(
r"(?i)(?:password|token|secret|api_key|apikey|credentials|"
r"private_key|access_key|authorization)",
r"(?i)\b(?:password|token|secret|api_key|apikey|credentials|"
r"private_key|access_key|authorization)\b(?=\s*(?:[=:,)}]|$))",
)


Expand Down
10 changes: 10 additions & 0 deletions desloppify/tests/detectors/security/test_rules.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,16 @@ def test_sensitive_log_entries_detect_secret_logs():
assert issues[0]["detail"]["kind"] == "log_sensitive"


def test_sensitive_log_entries_ignore_noncredential_token_vocabulary():
issues = rules_mod._sensitive_log_entries(
filepath="src/report.py",
line_num=12,
line='print(f"{count} token strip(s)")',
)

assert issues == []


# ── _looks_like_non_secret_value heuristic ────────────────


Expand Down
38 changes: 38 additions & 0 deletions desloppify/tests/detectors/security/test_security.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
from pathlib import Path
from unittest.mock import patch

import pytest

from desloppify.engine.detectors.security.detector import detect_security_issues
from desloppify.engine.policy.zones import FileZoneMap, Zone
from desloppify.languages.typescript.detectors.security.detector import detect_ts_security
Expand Down Expand Up @@ -298,6 +300,42 @@ def test_log_sensitive_console(self):
finally:
os.unlink(path)

@pytest.mark.parametrize(
"content",
[
'print("out tokens")',
'print(f"{count} token strip(s)")',
'print(f"folder token(s): {count}")',
'print(f"folder_token_strip({stem!r})")',
],
)
def test_log_sensitive_ignores_noncredential_token_vocabulary(self, content):
path = _write_temp_file(content)
try:
entries, _ = detect_security_issues([path], None, "python")
log_entries = [e for e in entries if e["detail"]["kind"] == "log_sensitive"]
assert log_entries == []
finally:
os.unlink(path)

@pytest.mark.parametrize(
"content",
[
"print(token)",
'logger.info("%s", credentials)',
'console.log("api_key=", apiKey);',
],
)
def test_log_sensitive_detects_bare_sensitive_values(self, content):
suffix = ".ts" if content.startswith("console") else ".py"
path = _write_temp_file(content, suffix=suffix)
try:
entries, _ = detect_security_issues([path], None, suffix.removeprefix("."))
log_entries = [e for e in entries if e["detail"]["kind"] == "log_sensitive"]
assert len(log_entries) == 1
finally:
os.unlink(path)


class TestCrossLangZoneFiltering:
def test_generated_zone_skipped(self):
Expand Down