Skip to content

fix: allow postflight triage with pending objectives - #789

Open
cavvy-dev wants to merge 1 commit into
peteromallet:mainfrom
cavvy-dev:fix/postflight-triage-objective-gate
Open

cavvy-dev wants to merge 1 commit into
peteromallet:mainfrom
cavvy-dev:fix/postflight-triage-objective-gate

Conversation

@cavvy-dev

Copy link
Copy Markdown

Problem

During postflight planning, next can prescribe plan triage while triage refuses
with “pending behind the current objective backlog.” The canonical queue treats
newly planned objectives as backlog in this lifecycle phase, but the triage-start
guard still treats a retained plan-start score as evidence of active execution.

This addresses the triage contradiction reported in #787, not the separate
recovered-item scan-gate behavior described there.

Fix

Honor explicitly persisted planning mode when evaluating the objective execution
guard. Retain the guard for execute-mode and legacy plans without a persisted
phase, and retain the separate unconfirmed-stage-report guard.

No objectives are resolved, skipped, or removed by this change.

Verification

  • New regression before fix: 1 failed, 3 passed.
  • Focused lifecycle/queue tests after fix: 39 passed.
  • Clean upstream checkout plus this patch: python -m pytest desloppify/tests/ -q
    — 5814 passed, 5 skipped.
  • Read-only evaluation against the affected saved plan now permits its prescribed
    planning action while retaining its 128 pending objective findings.
  • The prescribed triage runner now starts without an attested override.

The initial sandboxed full-suite attempt could not download required parser
assets. Re-running with network access passed; no tests were disabled.

github-actions Bot added a commit to citizenadam/desloppify that referenced this pull request Sep 26, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants