fix: isolate undo history for unsaved documents - #251
Open
Amandot wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue where
Cmd+Zcould unexpectedly clear content in newly created unsaved documents.Root Cause
MonacoEditorwas rendered without apathprop, causing different tabs to reuse the same Monaco text model and Undo/Redo history.When switching between tabs, content synchronization could create synthetic edits in the shared Undo stack. As a result, pressing
Cmd+Zcould undo beyond the user's actual edits and unexpectedly clear or restore content from another document.Fix
activeTab.id.EditorPaneto Monaco as thepath.Ctrl+Shift+Zsupport for Redo on non-Mac platforms.Tests
Added regression tests covering:
Verification
The following checks pass:
npm testnpm run lintnpx tsc --noEmitnpm run buildFixes #247