Skip to content

ignore#18

Closed
vyruss wants to merge 2 commits into
mainfrom
fix/issue-17-azure-app-role-load
Closed

ignore#18
vyruss wants to merge 2 commits into
mainfrom
fix/issue-17-azure-app-role-load

Conversation

@vyruss

@vyruss vyruss commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Review Change Stack

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key: "tools"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
📝 Walkthrough

Walkthrough

Adds a require_compactor() helper to ci/journey.sh that gates journey stories 6d and 6e on the compactor binary being present, adds a dedicated make -s compactor build step to ci/topo/vanilla.sh, and updates coldfront.ensure_attached() to eagerly run LOAD azure when an Azure storage secret exists.

Changes

CI Compactor Build and Guard

Layer / File(s) Summary
require_compactor helper and story guards
ci/journey.sh
Defines require_compactor() to verify $COMPACTOR is executable and emit a fail message on missing binary. Calls it at the start of story_compaction (6d) and story_maintenance (6e) so each story returns immediately when the compactor is absent.
Compactor build step
ci/topo/vanilla.sh
Adds a step that runs make -s compactor before the journey runs, aborting with an explicit error if the build fails.

Azure Eager Load in coldfront Extension

Layer / File(s) Summary
Eager Azure LOAD in ensure_attached()
extension/coldfront/coldfront--1.0.sql
Adds an EXISTS query against coldfront.storage_secret for storage_type = 'azure'; when a row is found, executes duckdb.raw_query('LOAD azure') inside the SECURITY DEFINER block before any lazy autoload can occur.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically identifies both main changes: Azure app-role extension loading fix and compactor CI gap closure, directly matching the changeset.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description accurately describes the two main changes: Azure extension pre-loading in ensure_attached() and compactor CI improvements with guards in journey.sh.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/issue-17-azure-app-role-load

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codacy-production

codacy-production Bot commented Jun 18, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@vyruss vyruss closed this Jun 18, 2026
@vyruss vyruss deleted the fix/issue-17-azure-app-role-load branch June 18, 2026 22:50
@vyruss vyruss restored the fix/issue-17-azure-app-role-load branch June 18, 2026 22:51
@vyruss vyruss reopened this Jun 18, 2026
@vyruss vyruss closed this Jun 18, 2026
@vyruss vyruss deleted the fix/issue-17-azure-app-role-load branch June 18, 2026 22:57
@vyruss vyruss changed the title fix: azure app-role extension load + close compactor CI gap (#17) ignore Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant