ignore#18
Conversation
|
Note
|
| Layer / File(s) | Summary |
|---|---|
require_compactor helper and story guards ci/journey.sh |
Defines require_compactor() to verify $COMPACTOR is executable and emit a fail message on missing binary. Calls it at the start of story_compaction (6d) and story_maintenance (6e) so each story returns immediately when the compactor is absent. |
Compactor build step ci/topo/vanilla.sh |
Adds a step that runs make -s compactor before the journey runs, aborting with an explicit error if the build fails. |
Azure Eager Load in coldfront Extension
| Layer / File(s) | Summary |
|---|---|
Eager Azure LOAD in ensure_attached() extension/coldfront/coldfront--1.0.sql |
Adds an EXISTS query against coldfront.storage_secret for storage_type = 'azure'; when a row is found, executes duckdb.raw_query('LOAD azure') inside the SECURITY DEFINER block before any lazy autoload can occur. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly and specifically identifies both main changes: Azure app-role extension loading fix and compactor CI gap closure, directly matching the changeset. |
| Docstring Coverage | ✅ Passed | Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Description check | ✅ Passed | The pull request description accurately describes the two main changes: Azure extension pre-loading in ensure_attached() and compactor CI improvements with guards in journey.sh. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
fix/issue-17-azure-app-role-load
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
Up to standards ✅🟢 Issues
|
No description provided.