Pin sonarqube-scan-action to a full commit SHA (v8.2.1)#10154
Open
kobihikri wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe SonarQube GitHub Actions workflow now uses a pinned commit for the scan action instead of the ChangesSonarQube action pinning
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, and thank you for pgAdmin.
Small CI supply-chain hardening, one line.
sonarqube-scan.ymlruns the scanner from a mutable branch ref, in the step that holds the SonarQube credentials:Whatever
masterhappens to point at executes with those secrets in scope; a branch can move after review, a full commit SHA cannot. This PR pins to the commit behind the current release, keeping the version visible:Verified:
gh api repos/sonarsource/sonarqube-scan-action/git/ref/tags/v8.2.1→2291811…. It's the only workflow ref in the repo on a branch rather than a tag, so behavior today is unchanged. (If you'd rather discuss on pgadmin-hackers first, happy to take it there — filing here since small workflow PRs have been merged from GitHub recently.)For transparency: I used AI assistance to spot and draft this; I verified the workflow content and the release SHA myself.
Summary by CodeRabbit