Skip to content

fix: default query_parsers engine to pg_query_protobuf#119

Closed
scottjacobsen wants to merge 1 commit into
pgdogdev:mainfrom
scottjacobsen:scottjacobsen/default-query-parsers-engine
Closed

fix: default query_parsers engine to pg_query_protobuf#119
scottjacobsen wants to merge 1 commit into
pgdogdev:mainfrom
scottjacobsen:scottjacobsen/default-query-parsers-engine

Conversation

@scottjacobsen

Copy link
Copy Markdown
Contributor

pgdog requires the engine field in [[query_parsers]] entries and fails to start when it is missing (the QueryParser config struct has no serde default for the field), but the chart only rendered engine when set and documented it as optional.

Always render engine, defaulting to pg_query_protobuf (pgdog's default engine), so omitting it in queryParsers values no longer produces a config pgdog can't parse.

  • templates/config.yaml: render engine unconditionally with a pg_query_protobuf default
  • test/values-pgdog-config-extras.yaml: add an entry without engine to exercise the default
  • values.yaml: document the default
  • bump chart to v0.71

Verified with test/test.sh (all passing) — rendered output:

[[query_parsers]]
database = "primary"
level = "off"
engine = "pg_query_raw"
[[query_parsers]]
database = "primary_mirror"
level = "session_control_and_locks"
engine = "pg_query_protobuf"

🤖 Generated with Claude Code

pgdog requires the engine field in [[query_parsers]] entries and fails
to start when it is missing, but the chart only rendered engine when
set, and documented it as optional. Always render it, defaulting to
pg_query_protobuf (pgdog's default engine).
@levkk

levkk commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Ooops. So sure I set a default there.

@levkk

levkk commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

I did not. Let me fix this in pgdog code. We don't want this setting exposed unless absolutely necessary.

@levkk

levkk commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Fixed in pgdogdev/pgdog#1176

@scottjacobsen

Copy link
Copy Markdown
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants