Skip to content

Port StatementRewrite::split_insert_stmt to the new parser#1180

Open
sgrif wants to merge 1 commit into
mainfrom
sg-port-split-insert-stmt
Open

Port StatementRewrite::split_insert_stmt to the new parser#1180
sgrif wants to merge 1 commit into
mainfrom
sg-port-split-insert-stmt

Conversation

@sgrif

@sgrif sgrif commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

This is mostly a straight port, with some minor control flow changes to make it read better. The only notable behavior change is that the params it stores are one indexed instead of zero indexed, and that it doesn't duplicate parameters that are used multiple times. This makes it behave nearly identically to the statement struct we use for multi-step updates, which I intend to unify this with in the long term.

This is mostly a straight port, with some minor control flow changes to
make it read better. The only notable behavior change is that the params
it stores are one indexed instead of zero indexed, and that it doesn't
duplicate parameters that are used multiple times. This makes it behave
nearly identically to the statement struct we use for multi-step
updates, which I intend to unify this with in the long term.
@sgrif sgrif requested review from levkk and meskill July 10, 2026 21:47
@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.50000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...frontend/router/parser/rewrite/statement/insert.rs 97.50% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@levkk levkk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants