Allowlist exact Puppies.com hosts and document false-positive review - #1835
Open
Sammy12357 wants to merge 1 commit into
Open
Allowlist exact Puppies.com hosts and document false-positive review#1835Sammy12357 wants to merge 1 commit into
Sammy12357 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe pull request adds guidance for reporting false positives and whitelists ChangesWhitelist updates
Mergeability Score: ⚪ Minimal · up to The change narrowly allowlists two exact first-party hosts and documents review guidance without broadening subdomain coverage; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
puppies.comandwww.puppies.comWhy
puppies.comis being flagged by Phantom even though neither it nor itswwwhost appears in this repository's Solana or Ethereum blocklists. That points to
a heuristic or an upstream reputation-source false positive rather than an
explicit entry in this repository.
There are multiple independently verifiable signals that these are established
first-party hosts:
https://www.puppies.com/over HTTPSPuppies.com, LLC: https://apps.apple.com/us/app/puppies-com-puppy-finder/id6474639316
it has operated since 2003: https://www.puppies.com/puppyfind
service and mobile app: https://www.puppies.com/help/puppies-com-terms-of-service
Puppies.com is a user-generated marketplace, so this change does not claim
that every listing or seller is trustworthy. It only prevents the verified
first-party website hosts from being treated as wallet-phishing domains.
Precision and security scope
This deliberately does not add
*.puppies.com. Only the apex and thewwwredirect target are excepted. Unreviewed subdomains, deceptive sibling domains,
and suffix tricks remain outside the allowlist.
The README guidance applies the same principle to future reports: use exact
hosts, require independently checkable evidence, document redirects, and treat
reputation scans as supporting rather than decisive evidence. This mirrors a
multi-signal URL-review approach while keeping the deployed data format
unchanged.
Validation
yarn install --frozen-lockfilenode ./ci.jsyarn run buildpuppies.comandwww.puppies.comare allowlisted, whileshop.puppies.com,fakepuppies.com, andpuppies.com.evil.exampleare notSummary by CodeRabbit
New Features
puppies.comandwww.puppies.comto the URL whitelist.Documentation