Add trust-gpg keys option to the update command#452
Open
wannevancamp wants to merge 1 commit into
Open
Conversation
Member
|
Did you actually try this before submitting it? Because it looks like the PR is incomplete: There is no actual implementation, you merely added it to the help output and the context parser. There is not even a means to query the option you added in the accompanying config object. Did you maybe forget to commit and push those? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
--trust-gpg-keysoption to the update command, bringing feature parity with the install command for GPG key management during updates. This will make it possible to runphive updatein the CI/CD.Example:
phive update --trust-gpg-keys 0x1234567890ABCDEF,ABCDEF1234567890