fix: correct domain reference in ADAE example comments (#163) - #164
Conversation
The comment 'Join ADSL variables with VS' incorrectly references the VS (Vital Signs) domain. Since this is the ADAE (Adverse Events) example, the comment should reference the AE domain instead. Fixes pharmaverse#163
bms63
left a comment
bms63
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!!
|
Thanks again for the approval. I checked the outstanding CI result: Links, Style, and Spellcheck all pass. The only failure is in “Build & Deploy Website” at “Publish PR docs in a subdirectory”, where Because that permission is controlled on the upstream workflow side, I can’t correct it from the fork. Could you advise whether the deployment failure can be ignored for this PR or re-run with the required permission? I’m happy to make any change if there is a patch-specific issue. |
|
Following up once more on the website workflow question. The PR remains approved, and the only failing check I can see is the repository-side permission error in “Publish PR docs in a subdirectory.” Could a maintainer confirm whether that check is required for merge, or rerun it with the required permission? I have not found a patch-specific failure. |
|
ah - this is due to forking the repo. all good. i will merge in and i made it so the forks bypass this action. probably should be a little stricter :) |
2 participants
What
Corrects a comment typo in the ADAE example files where the domain reference was incorrectly set to VS (Vital Signs) instead of AE (Adverse Events).
Changes
Context
The ADAE example joins ADSL variables with the AE domain (adverse events), not the VS domain (vital signs). The ADVS example files correctly reference VS. This is a comment-only fix with no functional impact.
Fixes #163