Skip to content

address #375 - #376

Merged
shajoezhu merged 7 commits into
mainfrom
375_cran_issue
Sep 14, 2026
Merged

shajoezhu merged 7 commits into
mainfrom
375_cran_issue

Conversation

@shajoezhu

Copy link
Copy Markdown
Contributor

first empty commit to reproduce the error

@github-actions
github-actions Bot requested a review from Melkiades as a code owner September 14, 2026 03:43
@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
exporters 💚 $4.28$ $-1.73$ $0$ $0$ $0$ $0$
pagination 💚 $6.63$ $-2.56$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
pagination 💚 $3.32$ $-1.26$ pagination_works

Results for commit b65847d

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename             Stmts    Miss  Cover    Missing
-----------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/format_value.R       272       6  97.79%   117, 235, 278, 290, 566, 574
R/generics.R           142      16  88.73%   148, 286-290, 492, 504, 535, 565, 673, 686, 707-714, 766, 784, 788, 790
R/labels.R              55       7  87.27%   51, 57, 66, 107, 133, 142, 146
R/matrix_form.R        702      35  95.01%   134, 174, 411, 531-532, 624, 638-641, 659, 690, 780-781, 795-800, 830-833, 893-894, 988-989, 1044, 1096, 1262, 1360, 1408, 1411, 1415
R/mpf_exporters.R      289      28  90.31%   2, 102-112, 157, 193, 238, 241, 246, 427-433, 437, 440, 444, 494, 573
R/page_size.R           42       1  97.62%   219
R/pagination.R         770      56  92.73%   327-330, 435-450, 540, 595, 600, 641, 679-690, 766, 878-879, 901-910, 1051, 1054, 1275, 1312-1316, 1333-1341, 1422, 1562-1563, 1579-1580, 1594-1595
R/tostring.R           783      66  91.57%   88, 296, 351, 421, 454, 462, 498, 555-558, 594, 660-663, 669-673, 676-679, 686-691, 774-775, 915-916, 981-988, 1038-1042, 1111, 1164, 1183-1187, 1198, 1216, 1233, 1248, 1346, 1389, 1434, 1520, 1559, 1613, 1620
R/utils.R                3       0  100.00%
R/zzz.R                 17       6  64.71%   28-33
TOTAL                 3075     221  92.81%

Diff against main

Filename           Stmts    Miss  Cover
---------------  -------  ------  -------
R/matrix_form.R       +1      -1  +0.15%
TOTAL                 +1      -1  +0.03%

Results for commit: 8812097

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Unit Tests Summary

  1 files    9 suites   13s ⏱️
 59 tests  59 ✅ 0 💤 0 ❌
436 runs  436 ✅ 0 💤 0 ❌

Results for commit 8812097.

♻️ This comment has been updated with latest results.

@Melkiades Melkiades left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks Joe

@shajoezhu
shajoezhu merged commit 2b5bcdc into main Sep 14, 2026
30 of 31 checks passed
@shajoezhu
shajoezhu deleted the 375_cran_issue branch September 14, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants