Skip to content

Serialize pkgdown publishers to avoid gh-pages push races - #378

Merged
shajoezhu merged 2 commits into
mainfrom
copilot/fix-pkgdown-docs-multi-version
Sep 22, 2026
Merged

shajoezhu merged 2 commits into
mainfrom
copilot/fix-pkgdown-docs-multi-version

Conversation

Copilot AI commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

The Pkgdown Docs 📚 / Multi-version docs 📑 failure was caused by concurrent workflows publishing to gh-pages. When one docs run advanced the branch mid-run, the other hit a non-fast-forward push rejection.

  • What changed

    • Added a shared workflow-level concurrency group to both docs publishers:
      • .github/workflows/docs.yaml
      • .github/workflows/release.yaml
    • Set cancel-in-progress: false so publishers queue instead of preempting each other.
  • Why this fixes the failure

    • main docs and release docs both write to gh-pages.
    • Serializing those workflows removes the race where two runs build against different gh-pages tips and the later push is rejected.
  • Workflow shape

    concurrency:
      group: pkgdown-publish-gh-pages
      cancel-in-progress: false

Co-authored-by: shajoezhu <3692541+shajoezhu@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job for multi-version docs Serialize pkgdown publishers to avoid gh-pages push races Sep 22, 2026
Copilot AI requested a review from shajoezhu September 22, 2026 09:20
@shajoezhu
shajoezhu marked this pull request as ready for review September 22, 2026 09:20

@shajoezhu shajoezhu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Unit Tests Summary

  1 files    9 suites   13s ⏱️
 59 tests  59 ✅ 0 💤 0 ❌
436 runs  436 ✅ 0 💤 0 ❌

Results for commit cfa9074.

♻️ This comment has been updated with latest results.

@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
exporters 💚 $3.51$ $-1.43$ $0$ $0$ $0$ $0$
pagination 💚 $5.37$ $-1.94$ $0$ $0$ $0$ $0$

Results for commit 8bf8e2c

♻️ This comment has been updated with latest results.

@github-actions

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename             Stmts    Miss  Cover    Missing
-----------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/format_value.R       272       6  97.79%   117, 235, 278, 290, 566, 574
R/generics.R           142      16  88.73%   148, 286-290, 492, 504, 535, 565, 673, 686, 707-714, 766, 784, 788, 790
R/labels.R              55       7  87.27%   51, 57, 66, 107, 133, 142, 146
R/matrix_form.R        702      35  95.01%   134, 174, 411, 531-532, 624, 638-641, 659, 690, 780-781, 795-800, 830-833, 893-894, 988-989, 1044, 1096, 1262, 1360, 1408, 1411, 1415
R/mpf_exporters.R      289      28  90.31%   2, 102-112, 157, 193, 238, 241, 246, 427-433, 437, 440, 444, 494, 573
R/page_size.R           42       1  97.62%   219
R/pagination.R         770      56  92.73%   327-330, 435-450, 540, 595, 600, 641, 679-690, 766, 878-879, 901-910, 1051, 1054, 1275, 1312-1316, 1333-1341, 1422, 1562-1563, 1579-1580, 1594-1595
R/tostring.R           783      66  91.57%   88, 296, 351, 421, 454, 462, 498, 555-558, 594, 660-663, 669-673, 676-679, 686-691, 774-775, 915-916, 981-988, 1038-1042, 1111, 1164, 1183-1187, 1198, 1216, 1233, 1248, 1346, 1389, 1434, 1520, 1559, 1613, 1620
R/utils.R                3       0  100.00%
R/zzz.R                 17       6  64.71%   28-33
TOTAL                 3075     221  92.81%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: cfa9074

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@shajoezhu
shajoezhu enabled auto-merge (squash) September 22, 2026 13:40
@shajoezhu
shajoezhu merged commit 9b4d896 into main Sep 22, 2026
57 checks passed
@shajoezhu
shajoezhu deleted the copilot/fix-pkgdown-docs-multi-version branch September 22, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants