1095 intermediate nesting - #1111
Merged
Merged
Conversation
…1095_intermediate_nesting
…1109) - Redocument using the up to date roxygen 8.0.0 (reverting most of the changes) - Added tests for `at_sibling` - Fixed multivariable label validation and made cut-split labels visible only for `at_sibling` branches. --------- Signed-off-by: David Muñoz Tord <david.munoztord@mailbox.org> Co-authored-by: Joe Zhu <joe.zhu@roche.com> Co-authored-by: shajoezhu <3692541+shajoezhu@users.noreply.github.com>
…1095_intermediate_nesting
Collaborator
Author
|
@munoztd0 I've moved your tests to test-nesting.R along with the ones I had locally, can you please convert the ones you have to use the |
munoztd0
marked this pull request as ready for review
August 24, 2026 14:35
munoztd0
marked this pull request as draft
August 24, 2026 14:36
munoztd0
marked this pull request as ready for review
August 24, 2026 14:59
…1095_intermediate_nesting
Collaborator
Author
|
All comments resolved. |
Collaborator
Author
|
clean scda.test insightsengineering/scda.test#255 and ready to merge @shajoezhu |
Signed-off-by: Joe Zhu <joe.zhu@roche.com>
Signed-off-by: Joe Zhu <joe.zhu@roche.com>
shajoezhu
enabled auto-merge (squash)
September 27, 2026 21:36
shajoezhu
dismissed
Melkiades’s stale review
September 28, 2026 01:55
changes were made. downstream checked ok. ready for merge
shajoezhu
disabled auto-merge
September 28, 2026 01:56
shajoezhu
enabled auto-merge (squash)
September 28, 2026 01:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intermediate nesting behavior, testing and documentation