adding reports - #1533
Merged
Merged
adding reports#1533
Conversation
Contributor
Unit Test Performance Difference
Additional test case details
Results for commit be3aa4c ♻️ This comment has been updated with latest results. |
Contributor
|
Code Coverage SummaryDiff against mainResults for commit: 6dfc6f8 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
findLink() scanned every anchor on the page, so a vignette using the words "validation report" as link text would have been rewritten instead of the navbar item. Scope it to the navbar. closest() and remove() are the only ES6-era APIs in an otherwise strict ES5 file; replace them with equivalents so the target is consistent. pickReport() now takes the maximum eligible report rather than the last match, so REPORTS no longer has to be kept sorted, and the header comment notes that the static fallback in _pkgdown.yml needs updating alongside it. Mirrors the same fixes on pharmaverse/formatters#377 and pharmaverse/rtables#1122.
Contributor
|
@shajoezhu Same three fixes as on pharmaverse/formatters#377 and pharmaverse/rtables#1122, pushed here too, plus a description since the body was the unfilled template.
All four copies of Verified for tern: the 0.9.11 report is a 200, One left for you across all four: an rc such as |
Melkiades
approved these changes
Sep 22, 2026
Melkiades
left a comment
Melkiades
left a comment
Contributor
There was a problem hiding this comment.
Approving. The mechanism is sound and I checked it end to end: the report URL is live, the current version resolves to it, older doc versions correctly drop the item, and the live nesttemplate navbar exposes the version exactly where detectVersion() looks. Three small fixes pushed, described above.
Contributor
Unit Tests Summary 1 files 89 suites 1m 20s ⏱️ Results for commit 6dfc6f8. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
pkgdown builds one static site per version, so a hardcoded link would freeze at whichever report was current when it was written.
pkgdown/extra.jsreads the version from the navbar and points the link at the newest report at or below it. Doc versions older than the first report drop the item entirely._pkgdown.ymlkeeps a static href as the fallback for readers with JavaScript disabled.Only 0.9.11 currently has a report, so 0.9.11 and later resolve to it and earlier doc versions get no navbar item.
DESCRIPTIONalso swapsRoxygenNote: 8.0.0forConfig/roxygen2/version: 8.1.0, which is unrelated to the navbar link.Same change as pharmaverse/formatters#377 and pharmaverse/rtables#1122.