Fix summarize_ancova() contrasts for arm levels with regex metacharacters (#1471) - #1540
Open
gwangjinkim wants to merge 1 commit into
Open
gwangjinkim wants to merge 1 commit into
gwangjinkim wants to merge 1 commit into
Conversation
…ters (pharmaverse#1471) The reference arm level was pasted unescaped into a regular expression when extracting the treatment level from the emmeans contrast labels, so levels such as "Tirzepatide + Placebo" gave empty difference, CI and p-value cells. Escape it with a new internal escape_regex() helper. Also match the extracted level with or without the parentheses emmeans adds, instead of stripping a trailing ")" unconditionally, which dropped the contrast for treatment levels such as "ARM B (x)" (snapshot updated). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VgDfDKtUjnHDRwMAo5HAdo
Melkiades
approved these changes
Oct 2, 2026
Melkiades
left a comment
Melkiades
left a comment
Contributor
There was a problem hiding this comment.
lgtm! Thanks @gwangjinkim for the addition ;)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reference arm level was pasted unescaped into a regular expression when extracting the treatment level from the emmeans contrast labels, so levels such as "Tirzepatide + Placebo" gave empty difference, CI and p-value cells. Escape it with a new internal escape_regex() helper.
Also match the extracted level with or without the parentheses emmeans adds, instead of stripping a trailing ")" unconditionally, which dropped the contrast for treatment levels such as "ARM B (x)" (snapshot updated).
Claude-Session: https://claude.ai/code/session_01VgDfDKtUjnHDRwMAo5HAdo
Pull Request
Fixes #1471