Skip inactive inline transforms on borrowed HTML - #278
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #278 +/- ##
=========================================
Coverage 92.18% 92.19%
- Complexity 3955 3967 +12
=========================================
Files 111 111
Lines 11052 11066 +14
=========================================
+ Hits 10188 10202 +14
Misses 864 864 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Finish the post-#277 hot-loop audit by avoiding inline scans and regex calls when the corresponding Djot syntax is absent.
On the 49,540-byte
carve-benchpublication document, repeated isolated PHP 8.5 tracing-JIT runs land at 2.60–2.87 ms minimum (16.48–18.19 MB/s), versus 3.25 ms / 14.52 MB/s before this final pass. The fastest stable run is now effectively level with the current 18.41 MB/s carve-php reference.How
These mirror the recent carve-php architecture work: syntax-family gates, C-level bulk scans, and zero inactive extension/transform work. Djot PHP already carries the other applicable improvements: bulk inline runs, block-marker short-circuiting, renderer dispatch tables, and listener allocation avoidance.
Correctness