Fix tests warning and notices - #537
Open
davidmpaz wants to merge 1 commit into
Open
Conversation
Add returns types to HashMap interface. Correct namespace on IssuerTest. Avoid using warning silence operator.
Collaborator
|
Hi, I cannot accept this PR : it breaks retro-compatibility. It's sometime hard, but it's probably possible to keep the compatibility with all PHP versions, even in this case. Edit : I've just merged #538 to fix the depreciations on CI |
Contributor
Author
|
Hi, sure totally understandable. Let me check on this again. Maybe there is a sweet spot for reducing some warning while keeping fully backward compatible Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
thanks for maintaining this project. Could we include this on the main-stream, these are some details I noticed when running the tests for the project when creating #536
Add returns types to HashMap interface.
Correct namespace on IssuerTest.
Avoid using warning silence operator.