Skip to content

Fix tests warning and notices - #537

Open
davidmpaz wants to merge 1 commit into
phpmetrics:masterfrom
davidmpaz:fix-tests-warnings
Open

Fix tests warning and notices#537
davidmpaz wants to merge 1 commit into
phpmetrics:masterfrom
davidmpaz:fix-tests-warnings

Conversation

@davidmpaz

Copy link
Copy Markdown
Contributor

Hi,

thanks for maintaining this project. Could we include this on the main-stream, these are some details I noticed when running the tests for the project when creating #536


Add returns types to HashMap interface.
Correct namespace on IssuerTest.
Avoid using warning silence operator.

Add returns types to HashMap interface. Correct namespace on IssuerTest.
Avoid using warning silence operator.
@Halleck45

Halleck45 commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Hi,

I cannot accept this PR : it breaks retro-compatibility.

It's sometime hard, but it's probably possible to keep the compatibility with all PHP versions, even in this case.

Edit : I've just merged #538 to fix the depreciations on CI

@davidmpaz

Copy link
Copy Markdown
Contributor Author

Hi,

sure totally understandable. Let me check on this again. Maybe there is a sweet spot for reducing some warning while keeping fully backward compatible

Thanks
David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants