Repository navigation
Misleading/old documentation in http://php.net/v8jsexception and V8Js::__construct #289
Description
- V8JsException is not guaranteed to have the method getJsFileName() defined, if it's a V8JsTimeLimitException
- The 2 subtypes of exceptions aren't documented in php.net (V8JsScriptException and V8JsTimeLimitException)
Also, https://secure.php.net/manual/en/v8js.construct.php is misleading, (for $parameters), passing names of globals stopped working for me in php 7.0 (I assume you moved away from that design?)
EDIT(June 7, 2017): __construct is also out of date, compare with what is currently in the readme
/**
* Initializes and starts V8 engine and returns new V8Js object with it's own V8 context.
* Snapshots are supported by V8 4.3.7 and higher.
* @param string $object_name
* @param array $variables
* @param array $extensions
* @param bool $report_uncaught_exceptions
* @param string $snapshot_blob
*/
public function __construct($object_name = "PHP", array $variables = [], array $extensions = [], $report_uncaught_exceptions = TRUE, $snapshot_blob = NULL)
{}
Activity
stesie commentedon Feb 7, 2017
Thanks for the bump, I'm aware that the doc on PHP.net is out of sync but have no idea (yet) how to update it.
I will reach out to doc team now :)
[-]Misleading/old documentation in http://php.net/v8jsexception[/-][+]Misleading/old documentation in http://php.net/v8jsexception and V8Js::__construct[/+]goulashsoup commentedon Aug 24, 2019
In addition it would be great if you could create a markdown file with all up-to-date runtime configuration directives. It is not clear if the directives mentioned in the php documentation are still in use. Other directives are randomly mentioned...
redbullmarky commentedon Jun 1, 2022
@stesie regular PR via here, perhaps?
https://github.com/php/doc-en/tree/master/reference/v8js
stesie commentedon Jun 1, 2022
To be honest I have no idea 🤷 I might even have write access to some stuff there, I don't know.
Never touched the documentation there. That SGML stuff always scared me away 😇