Skip to content

Simplify CXXOPTS#1926

Merged
phst merged 1 commit into
masterfrom
cxxopt
Jul 4, 2026
Merged

Simplify CXXOPTS#1926
phst merged 1 commit into
masterfrom
cxxopt

Conversation

@phst

@phst phst commented Jul 4, 2026

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the 'CXXOPTS' configuration in 'private/cc_config.bzl' by reorganizing the compiler-specific 'select' blocks. Specifically, it moves the '-fvisibility-inlines-hidden' option for GCC and Clang into the first selection block and removes the redundant empty Clang compiler selection. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@phst phst merged commit 9b89dc0 into master Jul 4, 2026
18 checks passed
@phst phst deleted the cxxopt branch July 4, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant