[diffs/editor] Fix some selection bug#906
Open
ije wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
When overlapping selections merge, the result takes its direction from the most recently created selection, so the merged caret stays where the user last put it. Two paths had no tests: when the latest selection is already backward, and when a later bare caret lands on the merged start and the direction is derived as backward. Add a test for each so this focus-preserving behavior is locked in.
Contributor
|
LGTM, nice fix. I pushed a test-only commit (70ccda0) on top of your branch; no source changes. While reviewing, the new direction handling in
Both exist so the merged caret stays where it was most recently placed, so I added one test for each to pin that focus-preservation behavior down. |
necolas
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shiftkey pressed