[gameroman]

No description provided.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/​eslint@​8.57.1 ⏵ 9.39.5	+1
	npm/​@​tsconfig/​node18@​18.2.6
	npm/​@​types/​node@​18.19.130
	npm/​expect-type@​1.4.0
	npm/​neostandard@​0.12.2
	npm/​@​arethetypeswrong/​cli@​0.18.5
	npm/​typescript@​5.9.3

View full report

[bjohansebas]

Hey, could you add the TypeScript test infrastructure we added in on-finished? Sorry for the delay. jshttp/on-finished#69

[socket-security]

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

[gameroman]

Basically, typescript can not automatically infer that the callback type is ErrorRequestHandler so if you don't provide the type param, it'll just infer it's params as any

The only way to solve this is to change everything completely, changing callback's param to an object like { err, req, res, next }, instead of 4 different params, this is what hono, elysiajs and other do

This would obviously require a new major so I haven't touched anything there

So just letting know that the current logic cannot be fully expressed in typescript without manually providing the type parameter on the user's side

[bjohansebas]

Good start! I found a few nits while doing the code review

[bjohansebas]

I'd like us to use the Path type from index.d.ts here as well, but unfortunately we'd end up breaking more than we'd gain, since it's been this way in the Express types for years.