Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #211
MATCHING_GROUP_REGEXPreads(?<=and(?<!as the start of a named group, so the text up to the next>became the key name. Routes like/(?<=\/f\/)(?<id>[0-9]+)$/got a key such as=\/f\/)(?<idinstead ofid, and if an unnamed group came after the lookbehind there were fewer keys than groups, sokey.namethrew and the request ended in a 500.A group name can't start with
=or!, so the name pattern now excludes them ([^=!>][^>]*). Lookbehinds are then skipped like other(?groups.Tests: added two cases to
test/route.js(two lookbehind routes with a named group, and a lookbehind followed by an unnamed and a named group). Existing named/unnamed group behaviour is unchanged.