Repository navigation
Allow filtering local IPs by candidate type - #1017
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1017 +/- ##
==========================================
+ Coverage 91.90% 92.07% +0.16%
==========================================
Files 46 46
Lines 5510 5536 +26
==========================================
+ Hits 5064 5097 +33
+ Misses 446 439 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sirzooro
left a comment
There was a problem hiding this comment.
Changes looks good, just update that comment.
Side note from AI review: raddr/rport in candidates still reveal internal address/port, what is not desirable for applications which hide host candidates for privacy reason. This would deserve separate PR.
|
@sirzooro thank you for the review, I'll add an example comment before I merge.
users can filter ICE extensions, we can make it more clear. |
|
Also this comment reminded me that we need to fix how we serialize extension from and to webrtc. it's currently kinda bad because I couldn't break the webrtc or ICE API when i added the parser. |
Change WithIPFilter to accept IPFilterInfo containing local IP and candidate type. context for this change: #899 (comment)
75d2040 to
bb1e43c
Compare
Description
#899 made it so IP filter works for stun and turn, which is the correct thing to do for privacy reasons and control, this change caused an issue for snowflake: #899 (comment) for v5, I propose we change the IP filter parameter from a string IP to a struct so user can filter by the candidate type or any other info we add in the future (we can add interfaces!).
Change WithIPFilter to accept IPFilterInfo containing local IP and candidate type.