Skip to content

Add SetExtensions, drop special raddr/rport/tcptype - #1022

Merged
JoTurk merged 1 commit into
mainfrom
jo/set-extensions
Oct 1, 2026
Merged

JoTurk merged 1 commit into
mainfrom
jo/set-extensions

Conversation

@JoTurk

@JoTurk JoTurk commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Description

When I added extension parser a while ago ab6e243 (this parser was needed for webrtc to drop old generation candidates pion/webrtc#2993)

We had to keep special treatments and APIs for raddr and rport, we couldn't break the candidates API to wire them so webrtc has to parse extensions again https://github.com/pion/webrtc/blob/0272096d3d032d31c590eb63731fbb795c02785e/icecandidate.go#L147-L203

This adds SetExtensions, drops all the raddr, rport and tcptype special parsers and APIs.

@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.47826% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.68%. Comparing base (4eeedad) to head (4ee08eb).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
candidate_base.go 95.74% 2 Missing ⚠️
candidate_host.go 50.00% 1 Missing ⚠️
candidate_peer_reflexive.go 50.00% 1 Missing ⚠️
candidate_relay.go 50.00% 1 Missing ⚠️
candidate_server_reflexive.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1022      +/-   ##
==========================================
- Coverage   91.90%   91.68%   -0.22%     
==========================================
  Files          46       45       -1     
  Lines        5536     5439      -97     
==========================================
- Hits         5088     4987     -101     
- Misses        448      452       +4     
Flag Coverage Δ
go 91.68% <93.47%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoTurk JoTurk changed the title Add SetExtensions, drop special raddr/rport Add SetExtensions, drop special raddr/rport/tcptype Sep 30, 2026
@JoTurk
JoTurk requested a review from Sean-Der October 1, 2026 01:29
@JoTurk
JoTurk force-pushed the jo/set-extensions branch from ac80ec4 to 4ee08eb Compare October 1, 2026 16:45
@JoTurk
JoTurk merged commit 4ee08eb into main Oct 1, 2026
26 of 28 checks passed
@JoTurk
JoTurk deleted the jo/set-extensions branch October 1, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant