Repository navigation
Add SetExtensions, drop special raddr/rport/tcptype - #1022
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1022 +/- ##
==========================================
- Coverage 91.90% 91.68% -0.22%
==========================================
Files 46 45 -1
Lines 5536 5439 -97
==========================================
- Hits 5088 4987 -101
- Misses 448 452 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JoTurk
force-pushed
the
jo/set-extensions
branch
from
September 30, 2026 21:48
919af81 to
f357066
Compare
JoTurk
force-pushed
the
jo/set-extensions
branch
from
September 30, 2026 21:50
f357066 to
ac80ec4
Compare
JoTurk
force-pushed
the
jo/set-extensions
branch
from
October 1, 2026 16:45
ac80ec4 to
4ee08eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When I added extension parser a while ago ab6e243 (this parser was needed for webrtc to drop old generation candidates pion/webrtc#2993)
We had to keep special treatments and APIs for raddr and rport, we couldn't break the candidates API to wire them so webrtc has to parse extensions again https://github.com/pion/webrtc/blob/0272096d3d032d31c590eb63731fbb795c02785e/icecandidate.go#L147-L203
This adds SetExtensions, drops all the raddr, rport and tcptype special parsers and APIs.