Repository navigation
Conversation
Member
|
our commit lint rules are a bit annoying ... |
The DTLS 1.3 server completes when it receives the client's Finished but still has to ACK it. That ACK may be queued before completion is signaled and dropping the outgoing packets loses it, so the client retransmits its last flight a second later. Only the DTLS 1.2 client has nothing more to send and drops its packets, while it keeps sending ACK attributes until it receives the server's last flight.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1024 +/- ##
==========================================
+ Coverage 91.68% 91.76% +0.07%
==========================================
Files 45 45
Lines 5439 5439
==========================================
+ Hits 4987 4991 +4
+ Misses 452 448 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DTLS 1.3 server completes when it receives the client's Finished but still has to ACK it. That ACK may be queued before completion is signaled and dropping the outgoing packets loses it, so the client retransmits its last flight a second later.
Only the DTLS 1.2 client has nothing more to send and drops its packets, while it keeps sending ACK attributes until it receives the server's last flight.
(comment now matches what I wrote in libwebrtc)